Comments by François Houdebert

thanks

the svg has been exported from lightburn( software used to pilot the laser cutting machine).

The SVG could probably be edited also by inkscape I suppose. If you have any improvements to the rules, I'd be happy to incorporate them, as they're important for introducing people to the games.

I'll update the svg occasionally, lightburn doesn't work at home (on linux).

It doesn't really matter if there are extra spare parts, the main thing is that the game is complete.

I made the change.

I've also been looking for ideas for a lion hawk icon distinct from the griffon icon.

If there were an acceptable candidate, it would probably still take quite some time to  to finalize.

Done.

Check your rabbit in daiseireigi. they are promoted by default in stag.

copied

the command to filter chess game would be :

gulp --no-default-games --modules src/games/chessbase build --prod

I suggest you update jocly with HGM's version of capablanca and my timurid's version: they now have a prelude allowing you to select a sub-variant.
this will remove the need

• carrera, janus, gothic
• babur, wild mirza,wild babur, wild timurid

You could also add Fantastic XIII and bigorra.

We could also ask the more general question of not keeping anything other than chess variants. Something to think about.

ok, taken into consideration

do you want me to replace the sprites Adam just sent for shogi on the pullreq branch?

I made the modification on my branch,

I'll wait to see if HGM wants us to do the same on the branch that will go into jocly.

you can also swap the 2d in the same *-set-view.js

It not clear to me, when there's an apostrophe, it's the general of jade that corresponds to the blacks, right?

I use gimp. if the general of jade should be white (player a), it could be changed in seireigi-shogi-model.js

keep me posted I'll have to make the change too.

Note that the SVG for laser cutting is updated with a rabbit.

Also the doc has been improved a bit in jocly.

thanks for the advice.

I have modified accordingly

19 is the size of handLayout

boardLayout :
0: "##............##" ​
1: "##............##"
​2: "##............##"
​3: "##............##" ​
4: "##............##" ​
5: "##............##" ​
6: "##............##"
​7: "##............##"
​8: "##............##" ​
9: "##............##" ​
10: "##............##" ​
11: "##............##" ​
length: 12

Should I add : Should I add " ##############" before and after?

the array length is 19

NBROWS-row-1,row: 13, 0

If you'd like to make an implementation of wa shogi, here are some unused jocly-compatible sprites that might come in handy.

To be seen if useful

In that case : I get in 2d with pictos

Uncaught TypeError: this.cbView.boardLayout[((NBROWS - row) - 1)] is undefined
    paintCells chu-seireigi-view.js:1509
    paintChannel chu-seireigi-view.js:1530
    draw chu-seireigi-view.js:941

Would this come from using the draw function wrongly in my view : chu-seireigi-view.js ?

Note that I have the impression that with the modified version the result is satisfactory with or without extra hand ranks.

That's why I'd like your opinion on grid-board-view.js, because I thought it would be useful to transfer this modification to the pullreq branch for jocly.