Ratings & Comments
The Wikipedia has it that the player with the weakest player has the Jade General, and the strongest player the King. I am not sure if and how we should implement that in Jocly.
I made the modification on my branch,
I'll wait to see if HGM wants us to do the same on the branch that will go into jocly.
Since this comment is for a page that has not been published yet, you must be signed in to read it.
It not clear to me, when there's an apostrophe, it's the general of jade that corresponds to the blacks, right?
In kanji sets, the player that moves first always has the King with the extra stroke. And it is true that the player who moves first is called Black (or Sente) in Shogi. It's just that in Jocly and the Mnemonic sets by H. G. Muller, the player that moves first has the white piece images by convention to make it easier for chess players.
you can also swap the 2d in the same *-set-view.js
It not clear to me, when there's an apostrophe, it's the general of jade that corresponds to the blacks, right?
Since this comment is for a page that has not been published yet, you must be signed in to read it.
You should only have to swap the King kanjis in the 2D Classic Seireigi sprites.
For the 3D pieces its as simple as swapping "sh-king" and "sh-jade" in the 3D piece definitions in the *-view.js files, so no problem there.
P.S. What I said above also applies to the Shogi Jocly implementations that use the King kanji on the biscandine site.
P.S.S. Also you have two extra rooks in your laser cutter SVG.
I use gimp. if the general of jade should be white (player a), it could be changed in seireigi-shogi-model.js
keep me posted I'll have to make the change too.
Thanks.
Out of curiosity, what program did you use to make the Seireigi Jocly sprites?
I am trying to fix a visual bug involving the 2d Kanji kings in Seireigi's implementation. The King with the extra stroke in the 2D Classic set is used for the player that moves second, when it should be used for the player that moves first.
Since this comment is for a page that has not been published yet, you must be signed in to read it.
Since this comment is for a page that has not been published yet, you must be signed in to read it.
Note that the SVG for laser cutting is updated with a rabbit.
Also the doc has been improved a bit in jocly.
Since this comment is for a page that has not been published yet, you must be signed in to read it.
Since this comment is for a page that has not been published yet, you must be signed in to read it.
Sorry, I was wrong. The real explanation is that they only jump to capture. It works correctly anyhow.
Ok, I thought it is like in tenjiku shogi!
Since this comment is for a page that has not been published yet, you must be signed in to read it.
Since this comment is for a page that has not been published yet, you must be signed in to read it.
They work the same as in the interactive diagram, only jumping over enemies.
Flying pieces still do not fly!
Since this comment is for a page that has not been published yet, you must be signed in to read it.
Looks like it. I have uploaded the new version to the site and have adapted them so the implementation will work properly with the CVP files.
Since this comment is for a page that has not been published yet, you must be signed in to read it.
Since this comment is for a page that has not been published yet, you must be signed in to read it.
It should be ok now
Since this comment is for a page that has not been published yet, you must be signed in to read it.
Looks good, save for a few errors:
---------------------
Setup Errors
---------------------
White Kirin and Phoenix are swapped from where they should be in the initial setup
Black King and Great Elephant are swapped from where they should be in the initial setup
---------------------
Promotion/Drop Errors
---------------------
Lance, Running Rabbit, Knight, Gold General, and Great Elephant are currently allowed to promote immediately if they are dropped into the promotion zone (this should not be the case)
Both Pawns in the hand spaces can be selected when multiple Pawns are in the hand)
Since this comment is for a page that has not been published yet, you must be signed in to read it.
thanks for the advice.
I have modified accordingly
Should I add : Should I add " ##############" before and after?
Indeed, you should, because you want the extra hand ranks to be colored black as well.
19 is the size of handLayout
boardLayout :
0: "##............##"
1: "##............##"
2: "##............##"
3: "##............##"
4: "##............##"
5: "##............##"
6: "##............##"
7: "##............##"
8: "##............##"
9: "##............##"
10: "##............##"
11: "##............##"
length: 12
Should I add : Should I add " ##############" before and after?
Strange. 13 should be a valid index for an array of length 19. That means the array should have some internal elements that are undefined. What happens if you print
console.log(
)?Since this comment is for a page that has not been published yet, you must be signed in to read it.
the array length is 19
NBROWS-row-1,row: 13, 0
This sounds like an out-of-bounds access on boardLayout. Are you sure you defined that array with sufficiently many ranks? To further diagnose the problem you could add console.log(NBROWS-row-1); just before the access to boardLayout in paintCells; then you could see in the console what the offending value is.
If you'd like to make an implementation of wa shogi, here are some unused jocly-compatible sprites that might come in handy.
To be seen if useful
In that case : I get in 2d with pictos
Would this come from using the draw function wrongly in my view : chu-seireigi-view.js ?
Note that I have the impression that with the modified version the result is satisfactory with or without extra hand ranks.
That's why I'd like your opinion on grid-board-view.js, because I thought it would be useful to transfer this modification to the pullreq branch for jocly.
I think that all that is needed is to make the 'row' loop run from 0 to NBROWS, and remove the -NBVHND from
this.cbView.boardLayout[NBROWS-NBVHND-row-1][col]
And then putting the extra hand ranks in the boardLayout defined in the game's view file. I don't think there are any other games yet that use extra hand ranks. I implemented that feature with Wa Shogi in mind.
The paintCells function is not involved in drawing the grid.
I had already looked at the sources, by looking at the chu-seireigi-view.js of the compiled version. Since you build Jocly without uglification all used source files are in there unmodified.
Your current setup for this game looks way better, but I did notice a few errors were made while making the new version. I also noticed a bug in the Hectochess implementation.
---------------------
Chu Seireigi Setup Errors
---------------------
White Kirin and Phoenix are swapped from where they should be in the initial setup
Black King and Great Elephant are swapped from where they should be in the initial setup
---------------------
Chu Seireigi Promotion/Drop Errors
---------------------
Pawn, Lance, Running Rabbit, Knight, Gold General, and Great Elephant are currently allowed to promote immediately if they are dropped into the promotion zone (this should not be the case)
White Copper General is put in same place as Black Lion in hand spaces, resulting in the hand space setup looking asymmetrical (White Copper General should be placed between the Great Elephant and Running Wolf)
(Also, because of this bug, a "King" may sometimes appear in current hand space of extra White Copper Generals/Black Lions for some reason...though this thankfully doesn't affect anything)
---------------------
Hectochess Castling Error
---------------------
When attempting to castle, the Champion's starting squares (b2/b9 and i2/i9) and queenside Knight starting squares (c2/c9) are not checked to see whether a piece is occupying them or not.
The change in paintCells was necessary because the grid wouldn’t display. May be that a better modification is possible, but I don't think I'm in a position to make it.
After a few modifications, current result
I don't know if you'd like to have a look at sources : latest to check grid-board-view.js
47 comments displayed
Permalink to the exact comments currently displayed.
I'll send you an updated pictogram spritesheet that you can use. Currently, the pictogram images still have the Kanji for the Kings since they are pulling from those locations.