Comments/Ratings for a Single Item
There was a syntax error, which I've now corrected. As a test, I updated your profile and changed it back.
No improvement. Now it just goes to an empty white page (without updating anything in the database)
I have now modified it to use the update_row function, which should fix things.
I had to make a change to a column name in the script, and I still couldn't leave the board size fields blank, but I successfully made the submission. I again got a 401 inside the submission page, but this time it seems to have been because IsMemberSubmitted
was 0; I modified the script to set that flag. There's another column IsLink
which is set as zero (not being set in the script; both here and in another older ML page of mine, so it's been like this for some time), but doesn't appear to have an adverse effect.
Should this script be calling update_row (or some other indexing func) instead of its ad hoc query?
Yes, these functions are more secure and error-proof than ad hoc code may be, and it's best to not reinvent the wheel each time we need to access the database. So, I have now rewritten the script to use update_row and replace_row. I have left the other code in comments in case I made a mistake and need to reference it.
What I've done for now is provide an individual default for each parameter instead of giving them all an empty string as the default. I'll do some more work later.
@Fergus, thanks! I had emptied boardrows in my submission.
I thought in the past I could put board rows/columns/levels/cells as empty and they'd populate as nulls. Either I'm wrong about that, or something has changed. I think being able to leave those fields blank for non-game pages is the most natural.
Should this script be calling update_row
(or some other indexing func) instead of its ad hoc query?
7:44 am CST would be 13:44 UTC, and I got this for that time:
[23-Jan-2023 13:44:07 UTC] PHP Fatal error: Uncaught PDOException: SQLSTATE[22007]:
Invalid datetime format: 1366 Incorrect integer value: '' for column
`chessvariants`.`Item`.`BoardRows` at row 1 in /home/chessvariants/public_html/index/membersubmission2.php:385
Stack trace:
#0 /home/chessvariants/public_html/index/membersubmission2.php(385): PDOStatement->execute()
#1 {main}
thrown in /home/chessvariants/public_html/index/membersubmission2.php on line 385
Instead of using replace
, I should probably use insert
if the row doesn't exist and update
if it does, as I have already fixed this problem for the update_row
function. Since BoardRows is not even a datetime field, this is a weird message, but the underlying problem is that replace
is getting an empty string instead of whatever it is expecting.
I just tried again, 7:44am CST, itemid MLlichess. I had added MSlichess before realizing I had forgotten to switch to a link item, so that's likely the problem, but I removed the Item and IndexEntry entries (and the MemberSubmissions never got created), and any other locations shouldn't affect the Replace into Item
query?
Also, as someone else reported recently: I can't edit another test entry (MLtestlink
) to have empty content, but without empty content I cannot use the forms to delete it. Which of these protections do we want to keep?
I'm not sure if this is due to the server move, but member-submission of External Link pages doesn't seem to be working.
As a preliminary test, I made a link page to PyChess, and it worked. So, I have not been able to repeat the problem you encountered. If you have any further problem with it, let me know the time and details do that I can check the error log.
I'll look into it tomorrow.
I'm not sure if this is due to the server move, but member-submission of External Link pages doesn't seem to be working. I started doing some debugging, and it seems to die in membersubmissions2.php when trying to execute the replaceitem query (but the error handling there doesn't trigger either), what is currently line 385.
For some reason, when using an image for the board in Game Courier, the file labels are positioned higher than they should be.
This is now fixed. In Chu Shogi, which you gave as an example, the file labels are now positioned at the right level.
For some reason, when using an image for the board in Game Courier, the file labels are positioned higher than they should be. Here's an example from Chu Shogi.
The differences between page revisions was handled by code I copied from another website. Fortunately, with the help of the PHP error log, I was able to fix it.
The diffs between page revisions don't seem to work anymore, possibly due to the server move. I get a short part of the introduction and no other text, and generally no highlighted diffs.
Same here. I tried to get this working in the spring. One of the guys (moderators) even tried to fix it manually for me. It just doesn't work. And it'd be very helpful if it did cause I would get notified when my opponents move.
By the way, I believe I did get the verification emails, they just didn't work.
Email verification not working (I have checked the spam folder).
Can you watch Fluidity please, I can’t add new variants but I have 5+ of them in keeping ready.
So how can I add my piece to Piececlopedia?! If I can;)))
From my previous post in this thread:
@ Fergus:
The preset won't let me resign in the following log (says to use Back Button on page of code) - earlier I had 2 similar problems resigning in recent games with Carlos with the Sac Chess preset, so something may have changed when we moved to a new server, perhaps:
I've since emailed Fergus (he'd not visited CVP site for some days), and he told me the problem with my log above is fixed (I did indeed resign successfully).
Anyone else having trouble resigning from a game due to their log's preset acting up (apparently) may now be able to successfully resign if they wish.
@ Fergus:
The preset won't let me resign in the following log (says to use Back Button on page of code) - earlier I had 2 similar problems resigning in recent games with Carlos with the Sac Chess preset, so something may have changed when we moved to a new server, perhaps:
That's what the Revisions page is for (in the top menu, Edit -> N revisions). Click the revision you want to select, press Ctrl-U to view the source code. You can then copy the relevant HTML sections into the editors in the Edit Page form.
I believe this is possible. It would be helpful if you posted the link to the page you want reverted.
25 comments displayed
Permalink to the exact comments currently displayed.
I cannot use the item quick-edit script (as an editor) because the form does not have the new BoardRealms input (though perhaps the quick edit can be deprecated now that the author list population isn't so slow), and the database apparently won't allow it to be null. Again, I really think allowing nulls for non-game items would be best, and BoardRealms should be defaulted to 1 in any forms.